-
Notifications
You must be signed in to change notification settings - Fork 350
debug: temporarily disable dynamic slots for "thread" userspace #10519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The "thread" userspace variant currently breaks when dynamic debug slots are used. Temporarily disable that configuration until fixed. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR temporarily disables dynamic debug slots for configurations using the SOF userspace proxy feature to work around a known compatibility issue. This is explicitly marked as a temporary fix until the underlying problem is resolved.
Changes:
- Modified the default value of
INTEL_ADSP_DEBUG_SLOT_MANAGERto be conditional, disabling it whenSOF_USERSPACE_PROXYis enabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
fixes QB failure in #10469 |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh do you think we have some hard coded offsets here that are clobbering dynamic slots ?
@lgirdwood hard to tell. I know the following - a single internal Intel CI userspace test fails with my PR #10469. That test is passing with the current SOF "main" though. And it's also passing with that PR's head which is 12 commits behind the current "main." So when bisecting those 12 commits it converged on the "enable dynamic debug slot" commit. That's why this PR. OTOH the current SOF "main" with the newer Zephyr version, to which my #10469 is updating is also failing. So that failure can be triggered by one of two updates - either dynamic debug slots or one of the almost 1000 Zephyr commits between those two versions. Currently bisecting them. |
|
Zephyr bisect: on the Zephyr side it's zephyrproject-rtos/zephyr@57b553b that breaks that QB test |
|
seems not needed any more |
Ack - seeing logs in PR failures now. |
The "thread" userspace variant currently breaks when dynamic debug slots are used. Temporarily disable that configuration until fixed.